Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if nb.metadata.title is set, default to that for notebook #672

Merged
merged 1 commit into from
Sep 15, 2017
Merged

if nb.metadata.title is set, default to that for notebook #672

merged 1 commit into from
Sep 15, 2017

Conversation

mpacer
Copy link
Member

@mpacer mpacer commented Sep 8, 2017

There is a title field in the notebook metadata as part of the nbformat v4 spec. We should use this feature if it is available.

This should solve #249.

@mpacer mpacer mentioned this pull request Sep 8, 2017
Closed
@mpacer
Copy link
Member Author

mpacer commented Sep 13, 2017

@Carreau can I get a review?

@takluyver takluyver added this to the 5.4 milestone Sep 15, 2017
@takluyver takluyver merged commit 710548f into jupyter:master Sep 15, 2017
@takluyver
Copy link
Member

Looks fine to me.

@mpacer mpacer mentioned this pull request Nov 13, 2017
Merged
@bluss bluss mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@mpacer @takluyver